Skip to content

Update 4.5.md bumping MySQL version #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

leonstr
Copy link
Contributor

@leonstr leonstr commented May 7, 2025

It looks like Moodle won't install with MySQL 8.0.0 because role was a reserved word, and is used by mdl_course_completion_criteria.role.

This restriction was removed in MySQL 8.0.1.

See https://dev.mysql.com/doc/mysqld-version-reference/en/keywords-8-0.html#keywords-8-0-detailed-R and https://moodle.org/mod/forum/discuss.php?d=467863 for more details.

It looks like Moodle won't install with MySQL 8.0.0 because `role` was a reserved word, and is used by `mdl_course_completion_criteria.role`.

This restriction was removed in MySQL 8.0.1.

See https://dev.mysql.com/doc/mysqld-version-reference/en/keywords-8-0.html#keywords-8-0-detailed-R and https://moodle.org/mod/forum/discuss.php?d=467863 for more details.
Copy link

netlify bot commented May 7, 2025

Deploy Preview for moodledevdocs failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 821e169
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/681b466ffcac9e000878c7a9

@andrewnicols
Copy link
Member

Hi @leonstr ,

Thanks for raising this. This documentation matches the information held within Moodle in the admin/environment.xml file. If this is a necessary change to the requirements then it must be in Moodle too.

It is worth noting that MySQL 8.0.1 was released in 2016 and is not supported. I would not expect anyone to be trying to install Moodle with 8.0.0 anyway.

@leonstr
Copy link
Contributor Author

leonstr commented May 13, 2025

@andrewnicols … and is not supported. I would not expect anyone to be trying to install Moodle with 8.0.0 – The documentation and environment.xml indicate that 8.0.0 is supported by Moodle and, as the forum link shows, assuming no one will be using this isn't valid.

I've opened MDL-85485 Require MySQL 8.0.1 in environment.xml for Moodle 4.5 for consideration.

@andrewnicols
Copy link
Member

When I say that 8.0.0 is not supported I mean that it is long sinceout of support by Oracle/MySQL. Anyone in their right mind would not consider using MySQL 8.0.0 - it even says this in their release notes. It's actually a development release and they say it should not be used in production. The first general availability relase of 8.0 was 8.0.11, but even this is no longer in support -- it was released in 2018. The current version is 8.0.42.

To be quite honest, I don't think there is much point in making a change to the environment because I'm not sure where the benefit is. No-one installing a new Moodle site on the minimum version of a dependency.

@leonstr
Copy link
Contributor Author

leonstr commented May 13, 2025

I would not expect anyone to be trying to install Moodle with 8.0.0 anyway and No-one installing a new Moodle site on the minimum version of a dependency. – I don't mind that there's resistance to changing this, but you keep assuming this could never really occur when it literally did a week ago.

@scara
Copy link

scara commented May 16, 2025

Hi @leonstr,
for your consideration: the first GA is 8.0.11 while 8.0.1 was still a dev one, though with that feature already available.

HTH,
Matteo

@leonstr
Copy link
Contributor Author

leonstr commented May 16, 2025

My point with this change is that the current text showing 8.0 as the minimum MySQL version implies that Moodle will work if one somehow has MySQL 8.0.0 whereas actually it does not work. And this specific issue has somehow arisen in the real world, so IMO consequently we should make this avoidable by including 8.0.1 as the minimum in the documentation and environment check. Why check the environment meets the requirements to run a Moodle version if we don't exclude a component version known not to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants