-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Moodle 4.1 docs #473
Conversation
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
a5ddbb5
to
18b3f81
Compare
⚡️ Lighthouse report for the deploy preview of this PR
|
18b3f81
to
c623459
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I've been playing a little bit with the auto-deployed version and everything seems to work ok. Using the versions drop-down is possible to switch between versioned docs (apis...) easily. So I think this PR per se is ok and can be accepted to get the first experiences with the multi-versioned docs.
Only points that I've found unnatural (or weird) are also related with the versions drop-down behaviour itself. Here there are a few points where I think that we could improve, all around that drop-down menu:
- Does the drop down need some label? Maybe not, but right now it looks like (to me, this is a 100% subjective feeling) it's floating in the middle of nowhere.
- If you hover the menu (or click on the "triangle") it correctly shows you the available options (master, 4.1 and legacy). Then can select any of them, all ok. But, if you click on the "name" of the current version, then you're redirected to the "base" document in that version. IMO, that's completely unexpected. The "name" should behave the very same than the "triangle" or become 100% disabled.
- Related with the above... the existence of the versions drop-down in non-versioned docs (say intro, releases, processes...) is really miss-leading (there aren't versions for those docs) and trying to switch of version (via "name" like in the previous point, or via "hover" or "triangle") leads you to the unexpected "base" page. Maybe we should hide or disable the drop-down completely in non-versioned pages?
Just those 1-2-3 strange things I found, for your consideration. As said, other than that... let's approve this now, yay!
Ciao :-)
Cool, thanks! |
This is our first version fork.
It was generated by running:
There were a few minor pages to modify: