Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn build #750

Closed
wants to merge 2 commits into from
Closed

yarn build #750

wants to merge 2 commits into from

Conversation

notebook-t
Copy link

@notebook-t notebook-t commented Sep 22, 2023 •
edited
Loading

@netlify
Copy link

netlify bot commented Sep 22, 2023 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 03196c9
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/650dbb0d79c06800093c0022
😎 Deploy Preview https://deploy-preview-750--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewnicols
Copy link
Member

Sorry, but what is this change? We only support one version of Node.
We also do not recommend using npm
And I'm not sure why we want to run webpack?

@github-actions
Copy link
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 69 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 59 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 60 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 50 🟠 87 🟢 92 🟢 100 🟢 100 Report

notebook-t
notebook-t commented Sep 22, 2023
View reviewed changes
Copy link
Author

@notebook-t notebook-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string = 'production': 'none' | 'development' | 'production'

@andrewnicols
Copy link
Member

andrewnicols commented Sep 22, 2023 via email

notebook-t
notebook-t commented Sep 23, 2023
View reviewed changes
Copy link
Author

@notebook-t notebook-t left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#750

20230909_172542

@moodle moodle locked as spam and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notebook-t @andrewnicols