Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge thirdpartylibs.xml in plugin names with 'work' #316

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

vmdef
Copy link
Contributor

@vmdef vmdef commented Nov 5, 2024

When removing files irrelevant to the tests, any files or folders containing the substring "work" remain untouched. This poses a problem if the plugin uses that substring.

See https://tracker.moodle.org/browse/MDLSITE-7849 for more details.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.83%. Comparing base (0eb6bf7) to head (bd5807f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   33.18%   32.83%   -0.35%     
==========================================
  Files          71       71              
  Lines        3209     3243      +34     
==========================================
  Hits         1065     1065              
- Misses       2144     2178      +34     
Flag Coverage Δ
check_upgrade_savepoints 0.46% <0.00%> (-0.01%) ⬇️
checkstyle_manipulations 0.00% <0.00%> (ø)
compare_databases 2.37% <0.00%> (-0.03%) ⬇️
continuous_manage_queues_validation 0.70% <0.00%> (-0.01%) ⬇️
define_excluded 1.11% <0.00%> (-0.02%) ⬇️
detect_conflicts 1.48% <0.00%> (-0.02%) ⬇️
diff_extract_changes 0.00% <0.00%> (ø)
git_sync_two_branches 2.03% <0.00%> (-0.03%) ⬇️
grunt_process 2.99% <0.00%> (-0.04%) ⬇️
illegal_whitespace 2.62% <0.00%> (-0.03%) ⬇️
list_valid_components 0.00% <0.00%> (ø)
mustache_lint 2.80% <0.00%> (-0.03%) ⬇️
mustache_lint_plugins 1.29% <0.00%> (-0.02%) ⬇️
php_lint 1.20% <0.00%> (-0.02%) ⬇️
prepare_npm_stuff 1.51% <0.00%> (-0.02%) ⬇️
remote_branch_checker 17.32% <100.00%> (-0.19%) ⬇️
remote_branch_reporter 0.00% <0.00%> (ø)
setup 0.00% <0.00%> (ø)
thirdparty_check 1.44% <0.00%> (-0.02%) ⬇️
travis-branch-checker 0.00% <0.00%> (ø)
upgrade_external_backup 1.60% <0.00%> (-0.02%) ⬇️
verifications 0.00% <0.00%> (ø)
verify_commit_messages 2.62% <0.00%> (-0.03%) ⬇️
verify_phpunit_xml 1.23% <0.00%> (-0.02%) ⬇️
versions_check_set 4.99% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junpataleta
Copy link
Contributor

Hi, @vmdef .

The change seems like it will ignore folders that start with work. Do we want to perform an exact match for the work folder instead? I think the pattern ^work/ suggested by @stronk7 works well for this.

Thoughts?

When removing files irrelevant to the tests, any files or folders containing the substring "word" remain untouched. This poses a problem if the plugin uses that substring.
@vmdef
Copy link
Contributor Author

vmdef commented Nov 14, 2024

Thank you, @junpataleta and @stronk7.

I agree that adding a "/" makes it more specific. I've amended the patch accordingly.

@vmdef
Copy link
Contributor Author

vmdef commented Nov 27, 2024

Hi @junpataleta.

Would you mind reviewing the patch again at your convenience?

@junpataleta junpataleta merged commit c687fa9 into main Dec 4, 2024
102 checks passed
@junpataleta
Copy link
Contributor

Thanks, @vmdef! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants