Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#134 Support os which have systemd #135

Merged
merged 2 commits into from
Jan 19, 2015
Merged

Conversation

mookjp
Copy link
Owner

@mookjp mookjp commented Jan 19, 2015

#134

I changed scripts/init_host_server to update docker to the latest version if operation system has systemd; not only if operation system is CoreOS.

init_host_server is made for creating Vagrant environment at first but it can be used to set up host machine.
I tested it on both Vagrant and EC2 image; CentOS 7 x86_64 (2014_09_29) EBS HVM-b7ee8a69-ee97-4a49-9e68-afaee216db2e-ami-d2a117ba.2 (ami-89634988) which has systemd as default.

@mookjp mookjp changed the title Support os which have systemd #134 Support os which have systemd Jan 19, 2015
@@ -35,12 +35,12 @@ mkdir -p /opt/pool/bin
export POOL_BIN_PATH=/opt/pool/bin
export PATH=${POOL_BIN_PATH}:$PATH:/usr/local/bin

if [[ -f /etc/os-release ]] && [[ $(cat /etc/os-release | grep "NAME=CoreOS") ]]; then
echo "CoreOS detected. Updating to latest docker.."
if [ `which systemctl` ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to use dollar sign instead of backquote. ref

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ainoya Thanks, I did not know about nesting on using back quote form.

@mookjp mookjp force-pushed the support-os-which-have-systemd branch from a40b8bf to 3ba8be0 Compare January 19, 2015 14:48
ainoya added a commit that referenced this pull request Jan 19, 2015
@ainoya ainoya merged commit d073d8b into master Jan 19, 2015
@ainoya ainoya deleted the support-os-which-have-systemd branch January 19, 2015 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants