[WIP] recondition: Allow to specify custom rated capacity for recondition logic #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic Signed-off-by: Andrew 'Necromant' Andrianov <[email protected]>
Signed-off-by: Andrew 'Necromant' Andrianov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This patchset improves battery reconditioning in a few ways. It's still WiP.
It allows to specify custom battery capacity for the 'recondition until rated capacity is reached'. I've added the dumb logic (from the calculation that 300mAh == 2500 sec), so that for devices with modded batteries and DIY variants can recondition properly (Mine has a 600mAh battery).
I've also tried to send the calculations to reconditioning GUI (So that the user knows sees, that say 2500 seconds is ~300mAh), but I'm not sure how would be best to patch it to GUI without breaking too many things or introduce hacks (I've last done things in C++/Qt ~7 years ago, so bear with me ;) ). For now I've hardcoded some things and set it up for a test run.
I also plan on implementing a timer, so that reconditioning to max capacity will not go beyond, say, 10 hours. Just for safety.