utils: Use QUrl/QUrlQuery to parse urls #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apart from not 'reinventing the wheel', this fixes urldecoding in logins e.g. cloudflare Signed-off-by: Andrew 'Necromant' Andrianov <[email protected]>
deXol
approved these changes
Aug 5, 2024
src/utils/TOTPReader.cpp
Outdated
| { | ||
| totp.login = totp.login.mid(1); | ||
| } | ||
| if (url.scheme().compare("otpauth") != 0) { |
src/utils/TOTPReader.cpp
Outdated
| { | ||
| qWarning() << "TOTP QR does not contain secret"; | ||
| } | ||
| if (url.host().compare("totp") != 0) { |
Signed-off-by: Andrew 'Necromant' Andrianov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from not 'reinventing the wheel', this fixes urldecoding in QR code logins that use urlencoded characters e.g. cloudflare.
When cloudflare's QR code was detected by mooltipass app, it decoded the login (which, in turn, was an email address) with %40 instead of @ and created another credential with no password. That in turn caused the app to misbehave, not update password (Perhaps related to #1233 ) and it took several attempts to delete the incorrect login and update.