Upgrade dependencies to polkadot-v1.1.0 #186
Conversation
Cargo.lock
Outdated
| @@ -2937,7 +3131,7 @@ dependencies = [ | |||
| [[package]] | |||
| name = "frame-try-runtime" | |||
| version = "0.10.0-dev" | |||
| source = "git+https://github.com/paritytech/substrate?branch=polkadot-v1.0.0#948fbd2fd1233dc26dbb9f9bbc1d2cca2c03945d" | |||
| source = "git+https://github.com/moonbeam-foundation/polkadot-sdk?branch=moonbeam-polkadot-v1.1.0#893898cb26c2d279877288f6cf67799905c7cca0" | |||
There was a problem hiding this comment.
Is this pointing to the right commit? I couldn't find 893898cb26c2d279877288f6cf67799905c7cca0 within the latest commits of moonbeam-polkadot-v1.1.0 branch (it seems to be in another repo), and I guess that's because you haven't merged your PR with all the cherry-picks on our polkadot-sdk fork. You should first merge that one, and then update this reference to point to the latest commit in our moonbeam-polkadot-v1.1.0 branch inside the polkadot-sdk fork before merging this PR.
|
The changes seem to be fine, but pay attention to the commit references. We should wait for moonbeam-foundation/polkadot-sdk#1 to be merged before merging this one (because you will need to update the references to the correct commit). |
Thanks Agustin, I will check and fix them before the merge. |
This is the PR upgrade dependencies to polkadot v1.1.0.