Add pallet_parameters. #2898
Closed
Add pallet_parameters. #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
reviewed
Aug 6, 2024
RomarQ
reviewed
Aug 6, 2024
librelois
added
B7-runtimenoteworthy
Co-authored-by: Rodrigo Quelhas <[email protected]>
RomarQ
approved these changes
Aug 7, 2024
RomarQ
previously approved these changes
Aug 7, 2024
|
Please not merge, we need MBF feedback to know the list of constants they want to move to storage |
RomarQ
reviewed
Aug 27, 2024
| pub mod runtime_config { | ||
| // for fees, 80% are burned, 20% to the treasury | ||
| #[codec(index = 0)] | ||
| pub static FeesTreasuryPercentage: Perbill = Perbill::from_percent(20); |
There was a problem hiding this comment.
This could probably be Percent instead of Perbill. But not an issue.
There was a problem hiding this comment.
It's to give ability to add more precision if needed in the future.
librelois
reviewed
Aug 27, 2024
| @@ -1124,6 +1124,10 @@ macro_rules! impl_runtime_apis_plus_common { | |||
| hex_literal::hex!( "0d715f2646c8f85767b5d2764bb27826" | |||
| "04a74d81251e398fd8a0a4d55023bb3f") | |||
| .to_vec().into(), | |||
| // Parameters Parameters | |||
There was a problem hiding this comment.
Parameters Parameters is a map, not a value.
This whitelist do nothing then, as we can whitelist only full keys
There was a problem hiding this comment.
Is there no option to whitelist an entire storage?
There was a problem hiding this comment.
I don't think so, we have to edit manually this list each time we add a parameter
librelois
reviewed
Aug 27, 2024
|
Closed in favor of #2923. (Branch should be on moonbeam repo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add pallet_parameters to allow setting constants using a root origin.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?