Generate weights per runtime #2939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchMoonbase runtime: 2184 KB (no changes) ✅ Moonbeam runtime: 2124 KB (no changes) ✅ Moonriver runtime: 2136 KB (no changes) ✅ Compared to latest release (runtime-3102)Moonbase runtime: 2184 KB (+244 KB compared to latest release) Moonbeam runtime: 2124 KB (+224 KB compared to latest release) Moonriver runtime: 2136 KB (+236 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master tarekkma/weights-per-runtime +/- ##
================================================================
- Coverage 80.93% 75.95% -4.98%
+ Files 286 352 +66
+ Lines 81965 88195 +6230
================================================================
+ Hits 66331 66985 +654
+ Misses 15634 21210 +5576
|
RomarQ
requested changes
Sep 11, 2024
TarekkMA
added
B7-runtimenoteworthy
|
@gonzamontiel can we close this PR in favor of #3019? |
Yes, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?