Retrieve state_version from WASM in export-genesis-state subcommand
#3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of a custom implementation
WASM runtime size check:Compared to target branchMoonbase runtime: 2416 KB (no changes) 🚨 Moonbeam runtime: 2408 KB (no changes) 🚨 Moonriver runtime: 2384 KB (no changes) ✅ Compared to latest release (runtime-3500)Moonbase runtime: 2416 KB (+464 KB compared to latest release) 🚨 Moonbeam runtime: 2408 KB (+472 KB compared to latest release) 🚨 Moonriver runtime: 2384 KB (+448 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master manuel/define-state-version-from-wasm +/- ##
=========================================================================
- Coverage 74.52% 74.51% -0.01%
Files 380 380
+ Lines 96102 96103 +1
=========================================================================
Hits 71611 71611
+ Misses 24491 24492 +1
|
manuelmauro
added
D3-trivial
RomarQ
reviewed
Feb 9, 2025
Comment on lines
+423
to
+426
| let state_version = sc_chain_spec::resolve_state_version_from_wasm::< | ||
| _, | ||
| HashingFor<Block>, | ||
| >(&storage, &executor)?; |
There was a problem hiding this comment.
When running moonbeam export-genesis-state --chain moonriver, the expected state_version is StateVersion::V1, but it returns StateVersion::V0.
I think the issue is on the executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Retrieve
state_versionfrom WASM blob inexport-genesis-statesubcommand.What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?