Add missing code to tracer extension #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgmichel
changed the title
tgmichel
changed the title
StackExecutorWrapper
tgmichel
changed the title
StackExecutorWrapper
nanocryk
approved these changes
Apr 23, 2021
crystalin
reviewed
Apr 23, 2021
| if let Some(ret) = (precompile)(address, &data, Some(gas_limit), &context) { | ||
| return match ret { | ||
| Ok((s, out, cost)) => { | ||
| let _ = self |
There was a problem hiding this comment.
@notlesh isn't this also what you recently fixed ?
There was a problem hiding this comment.
It is, however in our wrapper we need to do exactly what the evm is doing, even if it's wrong! Otherwise the trace won't be replicating the original transaction behaviour.
Of course once the PR is merged we can include that change in our wrapper. Once again, this can be avoided with the hook.
There was a problem hiding this comment.
Yes, it looks like it should effectively do the same thing.
|
Won't do, we want to go for the hook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Refactors the runner
trace_callandtrace_createin a singletracefunction.And adds missing:
callcontexts.What important points reviewers should know?
For missing precompile handling we have 2 options:
evm::StackExecutor::precompile.EvmConfig::Precompile::executeto the executor wrapper in our side.I decided to use the latter because we have access to it, and in both cases we are using the same PrecompileSet.
Is there something left for follow-up PRs?
EVM side is really not compatible with tracing. We enabled some accessors there to be able to mock it's internals, but we still need to duplicate a bunch of code on our side to make sure we behave trace in the same way that the original call was executed.
This PR is a clear demonstration that @nanocryk 's hook is better solution to avoid this type of situations.
Checklist