Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Routes between MRL and XCM and get moon chain fee balance in source #366

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

mmaurello
Copy link
Contributor

@mmaurello mmaurello commented Oct 8, 2024

  • Separate Chain Routes and Asset Route between MRL and XCM
  • Add moonChainFee balance builder in source for mrl
  • Calculate the moon chain fee balance in source and return it
  • Add peaqEVM ftm route config

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 743096b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "scripts" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could just use 1 class for both, but we would need to make types more complex. Don't spend time for that right now. If it will be needed, we can come back to it.

packages/mrl/src/getTransferData/getSourceData.ts Outdated Show resolved Hide resolved
return getBalance({
address: sourceAddress,
asset: route.source.chain.getChainAsset(route.source.moonChainFee.asset),
builder: route.source.moonChainFee?.balance,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
builder: route.source.moonChainFee?.balance,
builder: route.source.moonChainFee.balance,

@mmaurello mmaurello merged commit 2a54b33 into v3-next Oct 8, 2024
7 checks passed
@mmaurello mmaurello deleted the v3-next-mrl-setup-3 branch October 8, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants