Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused imports #1153

Merged
merged 3 commits into from
Oct 22, 2024
+9 −11
Merged

remove unused imports #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd9e3a9
remove unused imports
Yu-zh Oct 21, 2024
a098ecd
work around CI
bobzhang Oct 22, 2024
9978c82
tweak
bobzhang Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions immut/hashset/moon.pkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
"moonbitlang/core/array",
"moonbitlang/core/coverage",
"moonbitlang/core/immut/internal/sparse_array",
"moonbitlang/core/quickcheck",
"moonbitlang/core/tuple"
"moonbitlang/core/quickcheck"
],
"test-import": [
"moonbitlang/core/string",
Expand Down
6 changes: 6 additions & 0 deletions json/from_json_test.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,15 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/// FIXME: remove later, workround formatter bug
fn temp() -> Unit {
()
}

typealias TestX = Map[String, Int]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoorkin can you check why new line is missed here? note this caused license header check failure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to work around the formatter bug


test {
let _ = temp()
let u = { "x": 3, "y": 4 }
let j = u.to_json()
let h : TestX = @json.from_json!(j)
Expand Down
3 changes: 1 addition & 2 deletions option/moon.pkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"moonbitlang/core/builtin",
"moonbitlang/core/quickcheck",
"moonbitlang/core/quickcheck/splitmix",
"moonbitlang/core/coverage",
"moonbitlang/core/double"
"moonbitlang/core/coverage"
],
"targets": {
"panic_test.mbt": ["not", "native"]
Expand Down
1 change: 0 additions & 1 deletion sorted_set/moon.pkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"import": [
"moonbitlang/core/builtin",
"moonbitlang/core/array",
"moonbitlang/core/option",
"moonbitlang/core/quickcheck",
"moonbitlang/core/coverage"
Expand Down
3 changes: 0 additions & 3 deletions strconv/moon.pkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
"moonbitlang/core/builtin",
"moonbitlang/core/coverage",
"moonbitlang/core/double",
"moonbitlang/core/tuple",
"moonbitlang/core/char",
"moonbitlang/core/string",
"moonbitlang/core/uint64"
]
}
4 changes: 1 addition & 3 deletions string/moon.pkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"import": [
"moonbitlang/core/builtin",
"moonbitlang/core/coverage",
"moonbitlang/core/bytes",
"moonbitlang/core/char"
"moonbitlang/core/coverage"
],
"test-import": [
"moonbitlang/core/immut/list",
Expand Down