add argument 'capacity~' for @hashset.new

[myfreess]

No description provided.

[peter-jerry-ye-code-review]

‼️ This code review is generated by a bot. Please verify the content before trusting it.

Here are three observations from the provided git diff output:

1. Inconsistent Default Capacity Usage:

   • In the hashset.mbt file, the new function now accepts an optional capacity parameter with a default value of default_init_capacity. However, the entries field is still initialized with default_init_capacity instead of using the provided capacity parameter. This could lead to inconsistencies if the user provides a custom capacity. The entries field should also use the capacity parameter to ensure the internal array matches the specified capacity.

   - entries: FixedArray::make(default_init_capacity, None),
   + entries: FixedArray::make(capacity, None),

2. Incomplete Default Value in Interface:

   • In the hashset.mbti file, the new function's capacity parameter is documented as capacity~ : Int = ... The .. notation is unclear and might be a placeholder. It should explicitly specify the default value (default_init_capacity) to match the implementation in hashset.mbt.

   - new[K](capacity~ : Int = ..) -> Self[K]
   + new[K](capacity~ : Int = default_init_capacity) -> Self[K]

3. Potential Misalignment in growAt Calculation:

   • The growAt field is calculated using calc_grow_threshold(default_init_capacity), but it should likely use the provided capacity parameter instead. This ensures that the growth threshold is correctly calculated based on the actual capacity of the hash set.

   - growAt: calc_grow_threshold(default_init_capacity),
   + growAt: calc_grow_threshold(capacity),

These changes would ensure consistency and correctness in the implementation and interface of the hash set.

[coveralls]

Pull Request Test Coverage Report for Build 4758

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 83.054%

---

Totals
Change from base Build 4756:	0.0%
Covered Lines:	4857
Relevant Lines:	5848

---

💛 - Coveralls