Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update video links in readme.md #14

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

Kukicosmos
Copy link
Contributor

No description provided.

Copy link

peter-jerry-ye-code-review bot commented Sep 27, 2024

From the provided git diff output for the readme.md file, here are three observations and suggestions:

  1. Missing Links in Part 3 and Part 4:

    • Problem: The entries for "Part 3" and "Part 4" are missing video links.
    • Suggestion: Ensure that the video links are added to the table for completeness. This will help users access the relevant content easily.
  2. Inconsistent Formatting in Part 5:

    • Problem: The entry for "Part 5" has an empty cell for the video link, which is inconsistent with the previous parts that have video links.
    • Suggestion: If there is a video associated with "Part 5", it should be linked in the table. If not, consider adding a note or placeholder to indicate why it's empty for consistency.
  3. Missing Content in Part 6 and Part 7:

    • Problem: The entries for "Part 6" and "Part 7" are missing descriptions and possibly other details.
    • Suggestion: Fill in the missing details for "Part 6" and "Part 7" to provide a complete overview of the course content. This includes descriptions, video links, and any associated resources.

These suggestions aim to improve the readability and usability of the readme.md file by ensuring all parts are thoroughly described and linked to relevant resources.

readme.md Outdated Show resolved Hide resolved
Co-authored-by: Yang Ming-Tian <[email protected]>
@lynzrand lynzrand merged commit 60aad13 into moonbitlang:main Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants