Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move libriscv to custom fork with stdin enabled #19

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

lynzrand
Copy link
Collaborator

No description provided.

Copy link

Observations and Suggestions

  1. Git Submodule Update:

    • The URL for the libriscv submodule has been changed from https://github.com/fwsGonzo/libriscv to https://github.com/lynzrand/libriscv.git. This change should be carefully reviewed to ensure that the new repository is the correct and approved version. If not, it could lead to compatibility issues or introduce unverified code.
  2. Submodule Commit Update:

    • The commit hash for the libriscv submodule has been updated from 8d2a318ef58e2e40524a28a1d7f6ec93a450af06 to e068ef93bae20b1220d02276ad3f03e383a44e16. It's crucial to verify that this new commit does not break any existing functionality or dependencies. Testing the build and functionality with the new submodule commit is advisable.
  3. Consistency with Repository Standards:

    • Ensure that the new URL and commit adhere to your organization's repository standards and code review processes. If there are specific guidelines or approval processes for changing submodules, make sure they have been followed.

These observations are based on the provided git diff output and are meant to guide through the review process to ensure that the changes do not introduce any unintended issues.

@lynzrand lynzrand merged commit 2fb9566 into main Oct 22, 2024
1 check passed
@lynzrand lynzrand deleted the fix-rvlinux branch October 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant