-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test hints #289
add test hints #289
Conversation
Issues Detected in the Provided
|
crates/moon/src/cli/test.rs
Outdated
} | ||
let surface_targets = cmd.build_flags.target.clone().unwrap(); | ||
let targets = lower_surface_targets(&surface_targets); | ||
if cmd.update && targets.len() > 1 { | ||
return Err(anyhow::anyhow!("cannot update test on multiple targets")); | ||
} | ||
let display_backend_hint: Option<u16> = if targets.len() > 1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we remove if we put backend into end ?
Total tests: 0, passed: 0, failed: 0. [wasm]
Total tests: 0, passed: 0, failed: 0. [wasm-gc]
Total tests: 0, passed: 0, failed: 0. [js]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current situation, this is a good idea.
6a1d3f6
to
364e32f
Compare
moon test is different from other modes, this PR only adds hints for test