Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: tweak unzip path #545

Merged
merged 1 commit into from
Dec 31, 2024
Merged

minor: tweak unzip path #545

merged 1 commit into from
Dec 31, 2024

Conversation

Young-Flash
Copy link
Collaborator

No description provided.

Verified

This commit was signed with the committer’s verified signature.
shorwood Stanley Horwood
Copy link

‼️ This code review is generated by a bot. Please verify the content before trusting it.

Here are three observations from the provided git diff:

  1. Change in Extraction Directory:

    • The extraction directory for the tar command has been changed from ~/.moon/bin/ to ~/.moon/. This could potentially cause issues if the extracted files are expected to be directly in the bin directory. Ensure that the extracted files are correctly placed and accessible in the new directory structure.
  2. Change in Windows Archive Extraction:

    • Similarly, the Expand-Archive command for Windows has been modified to extract to $env:USERPROFILE/.moon/ instead of $env:USERPROFILE/.moon/bin/. This change should be verified to ensure that the extracted files are correctly placed and that the paths used in subsequent commands are still valid.
  3. Consistency Across Platforms:

    • Both the Unix and Windows sections have been updated to extract files to the .moon directory instead of .moon/bin. While this change is consistent across platforms, it’s important to ensure that all scripts and tools that rely on these files are updated to reflect the new directory structure. This includes any environment variables or paths that might be hardcoded to expect files in the bin directory.

These changes should be carefully tested to ensure that they do not break any existing functionality or workflows.

@Young-Flash Young-Flash merged commit 16670d0 into main Dec 31, 2024
5 checks passed
@Young-Flash Young-Flash deleted the minor branch December 31, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant