Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update windows install script #54

Closed
wants to merge 1 commit into from
Closed

Conversation

tonyfettes
Copy link
Contributor

No description provided.

@tonyfettes tonyfettes linked an issue Sep 2, 2024 that may be closed by this pull request
Copy link

  1. URL Change in Script: The URL in the irm command has changed from https://cli.moonbitlang.com/windows_moon_setup.ps1 to https://cli.moonbitlang.com/install/powershell.ps1. This might be a typo or a change that could affect the script's functionality. It's important to ensure that the new URL is correct and points to the intended script.

  2. Execution Policy Usage: The Set-ExecutionPolicy RemoteSigned -Scope CurrentUser command is used to allow PowerShell scripts to run. This might be necessary for the script execution, but it's important to ensure that this change doesn't introduce security risks, especially in a CI/CD environment. Consider if this policy setting is the most secure option for your workflow.

  3. Path Management: The path "C:\Users\runneradmin\.moon\bin" is being added to the GITHUB_PATH environment variable. Ensure that this path is indeed the correct path where the executables are stored. If the path changes or is incorrect, it could lead to errors in the subsequent steps of the workflow.

@tonyfettes
Copy link
Contributor Author

closed by #52

@tonyfettes tonyfettes closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window ci broke
1 participant