Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: add native_sub.c for sys package #93

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Conversation

Young-Flash
Copy link
Collaborator

No description provided.

Copy link

peter-jerry-ye-code-review bot commented Jan 17, 2025

‼️ This code review is generated by a bot. Please verify the content before trusting it.

After reviewing the git diff, here are three potential issues or observations:

  1. File Extension Inconsistency:

    • The file fs_native.mbt uses .mbt extension while ffi.mbti uses .mbti extension.
    • This might cause confusion about file type conventions in the project. It would be good to maintain consistency in file extensions unless there's a specific reason for the difference.
  2. Path Handling in Native Code:

    • In native_stub.c, the code uses platform-specific path separators (windows.h vs dirent.h).
    • There's no explicit handling of path separators conversion between different platforms, which could potentially cause issues when dealing with file paths across different operating systems.
  3. Error Handling:

    • The environment variable functions (set_env_var, unset_env_var) don't appear to have any error handling or return values to indicate success/failure.
    • This could be problematic if these operations fail, as the calling code won't know about the failure.

These are potential areas that might need attention depending on the project's requirements and use cases.

@Young-Flash Young-Flash merged commit a0d6afa into main Jan 20, 2025
11 of 12 checks passed
@Young-Flash Young-Flash deleted the sys_native_stub branch January 20, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant