Add inbound queue #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
reviewed
Nov 14, 2024
bridges/snowbridge/pallets/inbound-queue/src/xcm_message_processor.rs
Outdated
Show resolved
Hide resolved
girazoki
reviewed
Nov 15, 2024
| use snowbridge_router_primitives::inbound::{MessageProcessor, VersionedXcmMessage}; | ||
| use sp_runtime::DispatchError; | ||
|
|
||
| pub struct XcmMessageProcessor<T>(PhantomData<T>); |
There was a problem hiding this comment.
I would probably call it some other thing but it is likely that snowbridge will tell you how to name it. So for me this is good enough
There was a problem hiding this comment.
Reason why I named it XcmMessageProcessor as it expects incoming message to be converted to xcm. :) But, let's see what snowbridge thinks.
girazoki
reviewed
Nov 15, 2024
| use alloy_primitives::B256; | ||
| use alloy_sol_types::{sol, SolEvent}; | ||
|
|
||
| sol! { |
There was a problem hiding this comment.
sol! macro takes an event declaration in solidity and provides helper functions and also struct to work with that event data. Like encoding/decoding etc.
girazoki
approved these changes
Nov 15, 2024
ParthDesai
merged commit 4e6395c
into
tanssi-polkadot-stable2407
18 of 39 checks passed
chexware
pushed a commit
that referenced
this pull request
Nov 15, 2024
* modify inbound queue to support custom message processing * passively test tuple trait implementation * rename XCM to Xcm everywhere * add comment explaining MessageProcessor
chexware
pushed a commit
that referenced
this pull request
Nov 23, 2024
* modify inbound queue to support custom message processing * passively test tuple trait implementation * rename XCM to Xcm everywhere * add comment explaining MessageProcessor
tmpolaczyk
pushed a commit
that referenced
this pull request
Dec 31, 2024
* modify inbound queue to support custom message processing * passively test tuple trait implementation * rename XCM to Xcm everywhere * add comment explaining MessageProcessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.