Fix: benchmarking for pallet-data-preservers and pallet-registrar on Dancelight #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chexware
added
not-breaking
WASM runtime size check:Compared to target branchdancebox runtime: 1416 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2152 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master aleks-fix-data-preservers-benchmarking +/- ##
==========================================================================
- Coverage 65.24% 65.15% -0.09%
+ Files 329 330 +1
+ Lines 57701 57796 +95
==========================================================================
+ Hits 37646 37655 +9
+ Misses 20055 20141 +86
|
added 2 commits
December 16, 2024 16:38
tmpolaczyk
reviewed
Dec 16, 2024
girazoki
reviewed
Dec 17, 2024
girazoki
reviewed
Jan 2, 2025
girazoki
reviewed
Jan 2, 2025
…egistrar and removed DataPreserversBenchmarkHelper
# Conflicts: # chains/orchestrator-relays/runtime/dancelight/src/weights/pallet_data_preservers.rs
chexware
changed the title
tmpolaczyk
reviewed
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds benchmarking weights for
pallet-data-preserversandpallet-registrarto Dancelight.Changes:
RegistrarHandlerwhich reservesParaIdon Dancelight.ParaIdin failing benchmarking cases - Any value lower than 2000 will be overwritten by the currentLOWEST_PUBLIC_IDdefined in Polkadot SDK and the benchmarks will still fail after reserving aParaId