Implements per tube statistics #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mons
reviewed
Mar 22, 2023
| @@ -44,8 +44,8 @@ do | |||
| end | |||
|
|
|||
| require 'xqueue'.upgrade(box.space.utube, { | |||
| format = box.space.utube:format(), | |||
There was a problem hiding this comment.
have no sense.
If space has format, just omit it here
There was a problem hiding this comment.
i think that setting format in xqueue.upgrade is useless, and maybe we should deprecate this at all?
Mons
reviewed
Mar 22, 2023
Mons
reviewed
Mar 22, 2023
Mons
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds statistics for tubes.
Developer must set list of tubes they want to get statistics for. Initial load is performed the same way as for default by status statistics. _on_replace trigger is slightly patched to perform track status change inside tubes and records transitions.
xqueue:stats()now returns fieldtubealong withcountsandtransition. Each value fortubeis table ofcountsandtransitionwith the same semantics.Also added new meta-status
Sfor cross-tubes transitions (X already used as not exists). It is possible to :release() task in tubeAwith update{ '=', 'tube', 'B' }, with this operation task will be "removed" from tube A and "placed" into tube B.It is not the same as :ack + :put. So now, in statistics, if both tubes are monitored, user may see pair of transitions T->S (for tube A) and S->R (for tube B). S for tranSition (maybe you have better letter for this)