-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fn 1-12 to toolbar above keyboard to support screen switch #600
base: master
Are you sure you want to change the base?
Conversation
Limelight/Input/StreamView.m
Outdated
@@ -356,7 +356,7 @@ - (void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event { | |||
keyInputField.text = @"0"; | |||
#if !TARGET_OS_TV | |||
// Prepare the toolbar above the keyboard for more options | |||
UIToolbar *customToolbarView = [[UIToolbar alloc] initWithFrame:CGRectMake(0, 0, self.bounds.size.width, 44)]; | |||
UIToolbar *customToolbarView = [[UIToolbar alloc] initWithFrame:CGRectMake(0, 0, self.bounds.size.width > 1500 ? self.bounds.size.width : 1500, 44)]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you come up with 1500 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By test :(
Didn't find a solution to calculate the width before drawing. I am not familiar with programing on iOS. Any suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you come up with 1500 here?
New pull request has removed this magic number by correctly calculating the toolbar width. For completeness, it also adds F7-F12 to the toolbar.
The new UI layout also makes the "cross" button on another level to make it always visible.
…; Improve UI layout algorithm
This is great and a very needed functionality. I definately need it a lot. Alternatively, can there also be a special button like Next display just for switching the displays? Or a gesture, like three fingers swipe or 4 fingers swipe? |
Here is how it looks alike.
This modification made it possible to switch screen from iOS with software keyboard using the shortcut ctrl-shift-alt-fn[1-6].