-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Additional version tokens #34
Conversation
Adds {versionMinor}, {versionPatch}, {versionMonth} and {versionDay} tokens to allow more fine grained control when building the download-url for some edge cases. {versionMajorMinor} and {versionYearMonth} are deprecated (which will be reflected in documentation) as these can now be built manually i.e. as {versionMajor}.{versionMinor}. This makes them redundant, but they remain for backwards compatibility to keep this a non-breaking change.
@milesj Had a look into why the tests are failing, and it isn't due to these code changes - it looks like It's possible that running But I believe every PR is going fail the tests at the moment... 😬 |
Yeah seems unrelated, will merge through. Thanks! |
Run report for b980f3cf
|
Action | Time | Status | Info | |
---|---|---|---|---|
🟩 | SyncWorkspace |
7.3ms | Passed | |
🟩 | SetupToolchain(rust:1.84.0) |
1.2s | Passed | |
🟩 | SyncProject(rust, internal-schema) |
0.9ms | Passed | |
🟩 | InstallWorkspaceDeps(rust:1.84.0) |
607.6ms | Passed | |
🟩 | RunTask(internal-schema:build) |
33.2s | Passed | |
🟩 | RunTask(internal-schema:check) |
2m 2s | Passed | SLOW |
🟩 | RunTask(internal-schema:lint) |
2m 3s | Passed | SLOW |
🟥 | RunTask(internal-schema:test) |
5m 14s | Failed | SLOW |
Environment
OS: macOS
Matrix:
os = macos-latest
job = 0
Touched files
tools/internal-schema/CHANGELOG.md
tools/internal-schema/Cargo.toml
tools/internal-schema/src/proto.rs
Run report for b980f3cf
|
Action | Time | Status | Info | |
---|---|---|---|---|
🟩 | SyncWorkspace |
6.5ms | Passed | |
🟩 | SetupToolchain(rust:1.84.0) |
782ms | Passed | |
🟩 | SyncProject(rust, internal-schema) |
0.7ms | Passed | |
🟩 | InstallWorkspaceDeps(rust:1.84.0) |
434.6ms | Passed | |
🟩 | RunTask(internal-schema:build) |
25.4s | Passed | |
🟩 | RunTask(internal-schema:check) |
1m 49s | Passed | |
🟩 | RunTask(internal-schema:lint) |
1m 50s | Passed | |
🟥 | RunTask(internal-schema:test) |
6m 42s | Failed | SLOW |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
job = 0
Touched files
tools/internal-schema/CHANGELOG.md
tools/internal-schema/Cargo.toml
tools/internal-schema/src/proto.rs
Run report for b980f3cf
|
Action | Time | Status | Info | |
---|---|---|---|---|
🟩 | SyncWorkspace |
11.3ms | Passed | |
🟩 | SetupToolchain(rust:1.84.0) |
1s | Passed | |
🟩 | SyncProject(rust, internal-schema) |
1.4ms | Passed | |
🟩 | InstallWorkspaceDeps(rust:1.84.0) |
3.3s | Passed | |
🟩 | RunTask(internal-schema:build) |
2m | Passed | SLOW |
🟩 | RunTask(internal-schema:check) |
4m 18s | Passed | SLOW |
🟩 | RunTask(internal-schema:lint) |
4m 19s | Passed | SLOW |
🟥 | RunTask(internal-schema:test) |
8m 41s | Failed | SLOW |
Environment
OS: Windows
Matrix:
os = windows-latest
job = 0
Touched files
tools/internal-schema/CHANGELOG.md
tools/internal-schema/Cargo.toml
tools/internal-schema/src/proto.rs
See moonrepo/proto#711
Adds
{versionMinor}
,{versionPatch}
,{versionMonth}
and{versionDay}
tokens to allow more fine grained control when building the download-url for some edge cases.{versionMajorMinor}
and{versionYearMonth}
are deprecated (which will be reflected in documentation) as these can now be built manually i.e. as{versionMajor}.{versionMinor}
. This makes them redundant, but they remain for backwards compatibility to keep this a non-breaking change.I have assumed this will be released as
0.16.4
when bumping the version - if not then this will affect moonrepo/proto#712