Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Additional version tokens #34

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

tom-fletcher
Copy link
Contributor

@tom-fletcher tom-fletcher commented Feb 5, 2025

See moonrepo/proto#711

Adds {versionMinor}, {versionPatch}, {versionMonth} and {versionDay} tokens to allow more fine grained control when building the download-url for some edge cases.

{versionMajorMinor} and {versionYearMonth} are deprecated (which will be reflected in documentation) as these can now be built manually i.e. as {versionMajor}.{versionMinor}. This makes them redundant, but they remain for backwards compatibility to keep this a non-breaking change.

I have assumed this will be released as 0.16.4 when bumping the version - if not then this will affect moonrepo/proto#712

Adds {versionMinor}, {versionPatch}, {versionMonth} and {versionDay} tokens to allow more fine grained control when building the download-url for some edge cases.

{versionMajorMinor} and {versionYearMonth} are deprecated (which will be reflected in documentation) as these can now be built manually i.e. as {versionMajor}.{versionMinor}. This makes them redundant, but they remain for backwards compatibility to keep this a non-breaking change.
@tom-fletcher
Copy link
Contributor Author

tom-fletcher commented Feb 6, 2025

@milesj Had a look into why the tests are failing, and it isn't due to these code changes - it looks likepdk-test-utils is expecting strings without any ANSI color, and currently it is getting strings with color and so failing to match them. I'm unsure if this is a side-effect of moving to moon, as these checks haven't been changed for a while (perhaps there was no color output in the CI previously).

It's possible that running moon ci in the actions without the force color option would resolve (but at the expense of easier to read output in the CI checks), or it may be that pdk-test-utils needs to be updated to include the ANSI color codes when checking substrings (which will mean a bit of a run around updating the proto repository first). Currently deferring to maintainer preference on this one. 😄

But I believe every PR is going fail the tests at the moment... 😬

@milesj
Copy link
Contributor

milesj commented Feb 6, 2025

Yeah seems unrelated, will merge through. Thanks!

@milesj milesj merged commit b980f3c into moonrepo:master Feb 6, 2025
7 of 10 checks passed
Copy link

github-actions bot commented Feb 6, 2025

Run report for b980f3cf (macos-latest, 0)

Total time: 5m 49s | Comparison time: 8m 26s | Estimated savings: 2m 36s (30.9% faster)

Action Time Status Info
🟩 SyncWorkspace 7.3ms Passed
🟩 SetupToolchain(rust:1.84.0) 1.2s Passed
🟩 SyncProject(rust, internal-schema) 0.9ms Passed
🟩 InstallWorkspaceDeps(rust:1.84.0) 607.6ms Passed
🟩 RunTask(internal-schema:build) 33.2s Passed
🟩 RunTask(internal-schema:check) 2m 2s Passed SLOW
🟩 RunTask(internal-schema:lint) 2m 3s Passed SLOW
🟥 RunTask(internal-schema:test) 5m 14s Failed SLOW
Environment

OS: macOS
Matrix:

os = macos-latest
job = 0
Touched files
tools/internal-schema/CHANGELOG.md
tools/internal-schema/Cargo.toml
tools/internal-schema/src/proto.rs

Copy link

github-actions bot commented Feb 6, 2025

Run report for b980f3cf (ubuntu-latest, 0)

Total time: 7m 9s | Comparison time: 9m 12s | Estimated savings: 2m 2s (22.2% faster)

Action Time Status Info
🟩 SyncWorkspace 6.5ms Passed
🟩 SetupToolchain(rust:1.84.0) 782ms Passed
🟩 SyncProject(rust, internal-schema) 0.7ms Passed
🟩 InstallWorkspaceDeps(rust:1.84.0) 434.6ms Passed
🟩 RunTask(internal-schema:build) 25.4s Passed
🟩 RunTask(internal-schema:check) 1m 49s Passed
🟩 RunTask(internal-schema:lint) 1m 50s Passed
🟥 RunTask(internal-schema:test) 6m 42s Failed SLOW
Environment

OS: Linux
Matrix:

os = ubuntu-latest
job = 0
Touched files
tools/internal-schema/CHANGELOG.md
tools/internal-schema/Cargo.toml
tools/internal-schema/src/proto.rs

Copy link

github-actions bot commented Feb 6, 2025

Run report for b980f3cf (windows-latest, 0)

Total time: 10m 46s | Comparison time: 16m 30s | Estimated savings: 5m 43s (34.7% faster)

Action Time Status Info
🟩 SyncWorkspace 11.3ms Passed
🟩 SetupToolchain(rust:1.84.0) 1s Passed
🟩 SyncProject(rust, internal-schema) 1.4ms Passed
🟩 InstallWorkspaceDeps(rust:1.84.0) 3.3s Passed
🟩 RunTask(internal-schema:build) 2m Passed SLOW
🟩 RunTask(internal-schema:check) 4m 18s Passed SLOW
🟩 RunTask(internal-schema:lint) 4m 19s Passed SLOW
🟥 RunTask(internal-schema:test) 8m 41s Failed SLOW
Environment

OS: Windows
Matrix:

os = windows-latest
job = 0
Touched files
tools/internal-schema/CHANGELOG.md
tools/internal-schema/Cargo.toml
tools/internal-schema/src/proto.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants