BNK-370 generate multiple batches in a recon file #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonbornsteinMOOV
changed the title
jasonbornsteinMOOV
force-pushed
the
BNK-370-recon-file-generation
branch
from
d070921 to
f22cc2c
Compare
rowland66
approved these changes
Sep 22, 2023
|
|
||
| writer FileWriter | ||
| func (batch *batchMirrorBatch) write(buf *bytes.Buffer) error { |
There was a problem hiding this comment.
How big are these batches likely to get? Is storing them in memory ever going to be a problem?
There was a problem hiding this comment.
in a way, that's going to get tested when we use this for simulating volume.
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 58.11% 59.32% +1.21%
==========================================
Files 15 15
Lines 721 740 +19
==========================================
+ Hits 419 439 +20
Misses 250 250
+ Partials 52 51 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why Are Changes Being Made