Generate jni bindings #1380
Generate jni bindings #1380
Conversation
This commit gives a benchmark report on the use of '[]*ach.File' and '[]ach.File'. It intend to show the improvement in passing by values instead of passing by reference
this commit creates javainterop package that ports functions from the general moov/ach package that does not align with the gobind rules for java jni bindings generation. It does this to be able to release a proper generated code for java apis to all the ach library.
|
Can you include only the changes for JNI interop in this PR? |
|
Yes, that was what I intended to do .. I think I had some commit issues … not sure why the commits mixed up but I fixed it up manually. |
This commit ports exported types and methods to a single javainterop package to allow for ease generation of go bindings to allow for java application to be largely supported. It also updates the github actions workflow to generate the binding on push to master branches by access the 'make java' command in the makeFile
|
could you help take a look at the update. Thank you |
|
Trust you are doing great. Hopefully this passes the pending checks but i need a review from you on what i did to know if it fits for merging or if there is something more to do. Thank you. |
|
The ubuntu build is failing due to the test coverage. I though since we were porting the library the unit testing was not compulsory. I am not sure what I should do in this case. |
|
@adamdecaf were these changes never merged in? i am just following up from our discussion. #1373 (reply in thread) |
|
Correct they were not merged in. We still need to figure out a way to setup types/classes so the JNI layer supports them all. I've tried another way but there are tons of unsupported classes, which is annoying. See #1406 |
This PR is to realated to initial !1327 for generating java bindings for the ach library