Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: make NewBufferLogger safe to read/write across goroutines #314

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

adamdecaf
Copy link
Member

No description provided.

@adamdecaf adamdecaf changed the title log: make NewBufferLogger() safe to read/write across goroutines log: make NewBufferLogger safe to read/write across goroutines Jul 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Patch coverage: 76.47% and project coverage change: -0.09 ⚠️

Comparison is base (ad25204) 76.17% compared to head (42b117a) 76.08%.

❗ Current head 42b117a differs from pull request most recent head 5cd563b. Consider uploading reports for the commit 5cd563b to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   76.17%   76.08%   -0.09%     
==========================================
  Files          28       28              
  Lines         999     1012      +13     
==========================================
+ Hits          761      770       +9     
- Misses        175      179       +4     
  Partials       63       63              
Impacted Files Coverage Δ
log/logger_impl.go 86.77% <76.47%> (-2.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamdecaf adamdecaf merged commit 9323d66 into moov-io:master Jul 21, 2023
8 checks passed
@adamdecaf adamdecaf deleted the make-buffered-logger-safe branch July 21, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants