Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: merge arbitrary map's together #390

Merged
merged 1 commit into from
May 9, 2024

Conversation

adamdecaf
Copy link
Member

@adamdecaf adamdecaf commented May 8, 2024

Previously map[K]V types were overwritten, so APP_CONFIG_SECRETS would overwrite APP_CONFIG's map[K]V value. Now we merge the two maps together, which I would argue is the expected behavior. Structs merge together and maps are useful with arbitrary keys.

There are only a small few instances of map[K]V being used in configs and file-saver is the first instance where config-secrets.yml would overwrite part of config.yml.

@adamdecaf adamdecaf requested a review from InfernoJJ as a code owner May 8, 2024 21:56
@adamdecaf adamdecaf merged commit 46e4527 into moov-io:master May 9, 2024
8 checks passed
@adamdecaf adamdecaf deleted the merge-maps-together branch May 9, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants