MICR Valid Indicator is an optional field. #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thus 0 is considered a valid value in some circumstances and the file should not be rejected. TestICLFile was modified to be a table test including a file that previously failed to validate.
|
As a note: I'm focused on this particular field in this change because it's one that's been encountered in the wild and it's blocking. |
|
Thanks for the PR @dustin! I'm hoping to have it reviewed by the end of the day today. |
|
💯 @atonks2: thanks for getting this reviewed and merged so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus 0 is considered a valid value in some circumstances and the file should not be rejected.
TestICLFile was modified to be a table test including a file that previously failed to validate.
This is related to #160