Generated code improvements #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for simplification in the generation script and helps set a standard for each package, separating the models from various helpers and support methods.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 84.86% 84.86%
=======================================
Files 12 12
Lines 185 185
=======================================
Hits 157 157
Misses 24 24
Partials 4 4 ☔ View full report in Codecov by Sentry. |
rowland66
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for simplification in the generation script and helps set a standard for each package, separating the models from various helpers and support methods.
The focus is on the templates and generator. The rest of the files are renamed or added by the generator or have code moved from one place to another.
Everything has been manually verified that nothing has been lost.