Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass io.ReadCloser instances instead of files on harddrive, fixes #536 #537

Merged
merged 3 commits into from
Mar 12, 2024
Merged

pass io.ReadCloser instances instead of files on harddrive, fixes #536 #537

merged 3 commits into from
Mar 12, 2024

Conversation

m29h
Copy link
Contributor

@m29h m29h commented Mar 7, 2024

@m29h m29h requested a review from adamdecaf as a code owner March 7, 2024 16:36
@m29h
Copy link
Contributor Author

m29h commented Mar 7, 2024

Fixed code linting problem...
make check passes now in my environment

@adamdecaf can you rerun tests please

adamdecaf
adamdecaf approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@adamdecaf adamdecaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Appreciate the cleanup and saving disk space

@adamdecaf adamdecaf merged commit 33df3aa into moov-io:master Mar 12, 2024
17 checks passed
@adamdecaf
Copy link
Member

Releasing this in https://github.com/moov-io/watchman/releases/tag/v0.28.1

@m29h m29h deleted the issue-536 branch March 12, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdecaf adamdecaf adamdecaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downloaded sanction list text/csv files are not deleted after they are not needed any more
2 participants
@m29h @adamdecaf