Replaces egrep with grep -E in gvm_export_path function #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please resolve conflicts |
clcollins
force-pushed
the
replace_egrep
branch
from
56090ae to
6828887
Compare
|
Apologies @BenKnigge , I missed your message. I've rebased and fixed the conflict. |
clcollins
force-pushed
the
replace_egrep
branch
from
6828887 to
d9b2e74
Compare
`egrep` is listed as deprecated and in Fedora 38, is outputting the message "warnin: egrep is obsolescent". According to moovweb#431, the official release notes from Grep 3.8 state egrep has been deprecated since 2007. This PR replaces `egrep` in gvm_export_path with `grep -E`. `egrep` is mentioned in a couple of the files in `./examples/native/`, but as I don't think they're critical to the use of GVM, I have not attempted to replace them. Fixes moovweb#431 Signed-off-by: Chris Collins <[email protected]>
clcollins
force-pushed
the
replace_egrep
branch
from
d9b2e74 to
fe7098c
Compare
|
I'm in favor of having this merged. |
|
is this going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
egrepis listed as deprecated and in Fedora 38, is outputting the message "warning: egrep is obsolescent". According to #431, the official release notes from Grep 3.8 state egrep has been deprecated since 2007.This PR replaces
egrepin gvm_export_path withgrep -E.egrepis mentioned in a couple of the files in./examples/native/, but as I don't think they're critical to the use of GVM, I have not attempted to replace them.Fixes #431
Signed-off-by: Chris Collins [email protected]