Edu and Amy's mainly Sequoia related fixes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ASentientBot
commented
Nov 25, 2024
ASentientBot
commented
- photos missing thumbnails, missing library tab, moments crash
- screenshot colors and fullscreen animation
- accessibility zoom
- hide buggy notification centre blur
- hide buggy weather animation
- safari animation crash
- mb2 not refreshing and crashes after ota
- misc build issues and regressions on older target
apparently stubber 2 can't dlopen sl on a sequoia host lol. stupid to keep fixing stuff for stubber 2 but. im lazy
Co-Authored-By: covasedu <[email protected]>
Co-Authored-By: covasedu <[email protected]>
im dumb Co-Authored-By: covasedu <[email protected]>
this seems to have been added at some point to work around a menu bar 2 compilation error. it confused me for absolute ages. also remove a sentient patcher case that's never used lol Co-Authored-By: covasedu <[email protected]>
missed some `MAJOR == 14` oops 🤦🏻♀️ Co-Authored-By: covasedu <[email protected]>
Co-Authored-By: covasedu <[email protected]>
WHAT Co-Authored-By: covasedu <[email protected]>
no more compiler warnings with SL shim. also remove some random logging and comments (lol "FUNCTIONS FROM EDUCOVAS" in Defenestrator3.m? that's mostly everything these days. misleading and unfair to him.) etc etc
yay no more compiler warnings at all
@covasedu asked me to do this bc it looks worse in sequoia Co-Authored-By: covasedu <[email protected]>
based on talagent ips from @covasedu, return early in some more cases that i missed Co-Authored-By: covasedu <[email protected]>
this is only supposed to show during user switches. i had this literally in the Cat shims and forgot since Big Sur lol
hopefully work around an issue where text color was calculated too early in login Co-Authored-By: covasedu <[email protected]>
apparently this crashes on Monterey for some reason, so revert the workaround for pre-Sequoia versions Co-Authored-By: covasedu <[email protected]>
@covasedu says CADisplayLink is unavailable on older versions and the shim wasn't needed anyways. leave it as a stub though or stubber 2 will effectively treat it as a nostub (lol) and idk if this will cause a missing symbol crash Co-Authored-By: covasedu <[email protected]>
no idea how to fix them yet. now it's a plain color Co-Authored-By: covasedu <[email protected]>
dubious Co-Authored-By: covasedu <[email protected]>
Co-Authored-By: covasedu <[email protected]>
im stupid, ofc just hiding one line wouldn't fix @covasedu's compiler error on ventura. this should however 😅 Co-Authored-By: covasedu <[email protected]>
|
only merge to sequoia branch for now bc idk if any regressions on older targets still? @covasedu will know this though |
as discussed on discord, check at runtime to avoid crash on 15.2 but still transition on any possible version Co-Authored-By: covasedu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.