Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issues with security.create_token() and Unicode problems #4

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fixes issues with security.create_token() and Unicode problems #4

wants to merge 11 commits into from

Commits on Jul 10, 2011

  1. Fixes division operation behavior in create_token() 

    * The function can now accept a numerical base argument.
* All usages have been updated to return expected
  hexadecimal string.
* Tests have been added for decimals.
* All create_token() tests pass.
* ``bytes`` is a Python 2.6+ type not available
  in Python 2.5. This patch fixes it with a suitable
  replacement.

Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    7742431 View commit details
    Browse the repository at this point in the history

  2. Updates commentary. 

    Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    9d6e768 View commit details
    Browse the repository at this point in the history

  3. Fixes issues with the json module. 

    * You cannot name a module "json" and import "json"
  from within it. This import test had been failing
  all this time. The module has been renamed to
  "escape" for all the tests to work.

* Stray modules (also because they are named "json")
  can pollute the Python namespace and cause our
  imports to fail. We're expecting Python's json
  module, but we can end up receiving a stray
  module named json. Therefore, we test whether
  we're using Python's module.

* All tests now pass.

Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    74d9781 View commit details
    Browse the repository at this point in the history

  4. Makes urlparse imports portable. 

    Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    af58565 View commit details
    Browse the repository at this point in the history

  5. Moves webapp2.py into webapp2/__init__.py 

    * Everything in a single module seems fine for a start
  but gets unweildy very fast.

Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    824cb1a View commit details
    Browse the repository at this point in the history

  6. Removes executable permissions from webapp2/__init__.py 

    Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    7fadf72 View commit details
    Browse the repository at this point in the history

  7. Adds types module to transparently convert between types. 

    Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    9d672cc View commit details
    Browse the repository at this point in the history

  8. Use bytes() instead of str() wherever byte strings are required. 

    Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    784d55c View commit details
    Browse the repository at this point in the history

  9. All tests pass with portable byte string/unicode string conversion. 

    Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    281f34a View commit details
    Browse the repository at this point in the history

  10. Ignore editor specific files. 

    Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    6c94cf0 View commit details
    Browse the repository at this point in the history

  11. Adds types module justification to its documentation. 

    Signed-off-by: Gora Khargosh <[email protected]>
    @gorakhargosh
    gorakhargosh committed Jul 10, 2011
    Configuration menu
    Copy the full SHA
    30a7a25 View commit details
    Browse the repository at this point in the history