Merge pull request #288 from jayvdb/use-git-url-parser

Revert use of giturlparse

.moban.cd/moban.yml

@@ -24,7 +24,7 @@ dependencies:
   - appdirs>=1.2.0
   - crayons>= 0.1.0
   - GitPython>=2.0.0
-  - giturlparse>=0.9.1
+  - git-url-parse>=1.2.2
 description: Yet another jinja2 cli command for static text generation
 scm_host: github.com
 lint_command: make lint install_test format install update

.moban.d/travis.yml

@@ -10,7 +10,6 @@ matrix:
 {%block custom_python_versions%}
 python:
   - &pypy2 pypy2.7-6.0
-  - 3.8-dev
   - 3.7
   - 3.6
   - 3.5

.travis.yml

@@ -6,7 +6,6 @@ notifications:
   email: false
 python:
   - &pypy2 pypy2.7-6.0
-  - 3.8-dev
   - 3.7
   - 3.6
   - 3.5

min_requirements.txt

@@ -4,4 +4,4 @@ lml==0.0.9
 appdirs==1.2.0
 crayons== 0.1.0
 GitPython==2.0.0
-giturlparse==0.9.1
+git-url-parse==1.2.2

moban/repo.py

@@ -44,14 +44,12 @@ def git_clone(requires):
 
 def get_repo_name(repo_url):
     import giturlparse
+    from giturlparse.parser import ParserError
 
     try:
-        repo = giturlparse.parse(repo_url)
-        name = repo.repo
-        if name.endswith("/"):
-            name = name[:-1]
-        return name
-    except AttributeError:
+        repo = giturlparse.parse(repo_url.rstrip("/"))
+        return repo.name
+    except ParserError:
         reporter.report_error_message(
             constants.MESSAGE_INVALID_GIT_URL % repo_url
         )

requirements.txt

@@ -4,4 +4,4 @@ lml>=0.0.9
 appdirs>=1.2.0
 crayons>= 0.1.0
 GitPython>=2.0.0
-giturlparse>=0.9.1
+git-url-parse>=1.2.2

setup.py

@@ -73,7 +73,7 @@
     "appdirs>=1.2.0",
     "crayons>= 0.1.0",
     "GitPython>=2.0.0",
-    "giturlparse>=0.9.1",
+    "git-url-parse>=1.2.2",
 ]
 SETUP_COMMANDS = {}
 

tests/test_repo.py

@@ -125,14 +125,16 @@ def test_update_existing_with_reference_parameter(
 
 def test_get_repo_name():
     repos = [
-        "https://github.com/sphinx-doc/sphinx",
+        "https://github.com/repo-abc-def/repo",
         "https://github.com/abc/repo",
         "https://github.com/abc/repo.git",
         "https://github.com/abc/repo/",
-        "[email protected]:moremoban/moban.git",
+        "[email protected]:abc/repo.git",
+        "[email protected]:abc/repo.git",
+        "git://github.com/abc/repo.git",
     ]
     actual = [get_repo_name(repo) for repo in repos]
-    expected = ["sphinx", "repo", "repo", "repo", "moban"]
+    expected = ["repo"] * len(repos)
     eq_(expected, actual)