Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove action type plugins #233

Merged
merged 7 commits into from
May 8, 2020
Merged

Remove action type plugins #233

merged 7 commits into from
May 8, 2020

Conversation

torotil
Copy link
Contributor

@torotil torotil commented May 4, 2020

This is a bit of refactoring spawned by #228 and earlier changes (eg in 6b47d75). After moving defaultTemplateNid() into ActionBase the only thing the ActionType (former TypeBase) class is good for is to query the $info array. isEmailProtest() will be removed soon, then isDonation() will be the only method left.

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #233 into 7.x-2.x will decrease coverage by 0.04%.
The diff coverage is 82.05%.

Impacted file tree graph

@@              Coverage Diff              @@
##             7.x-2.x     #233      +/-   ##
=============================================
- Coverage      44.08%   44.04%   -0.05%     
+ Complexity      1806     1801       -5     
=============================================
  Files            282      281       -1     
  Lines          10104    10093      -11     
  Branches         154      154              
=============================================
- Hits            4454     4445       -9     
+ Misses          5647     5645       -2     
  Partials           3        3              
Impacted Files Coverage Δ Complexity Δ
...on_email_to_target/src/Wizard/ConfirmationStep.php 0.00% <ø> (ø) 2.00 <0.00> (ø)
campaignion_action/src/ActionBase.php 55.55% <66.66%> (-2.63%) 29.00 <7.00> (+5.00) ⬇️
campaignion_action/src/ActionType.php 75.00% <75.00%> (ø) 3.00 <3.00> (?)
campaignion_action/campaignion_action.module 35.97% <100.00%> (+0.93%) 0.00 <0.00> (ø)
campaignion_action/src/Loader.php 54.54% <100.00%> (-4.48%) 25.00 <0.00> (-2.00)
campaignion_email_to_target/src/Action.php 76.92% <100.00%> (-1.02%) 27.00 <1.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3ab2e...3abc3cd. Read the comment docs.

@torotil torotil force-pushed the remove-action-types branch 2 times, most recently from dc6d965 to 809d01c Compare May 7, 2020 08:48
@torotil torotil force-pushed the remove-action-types branch from 809d01c to 3abc3cd Compare May 7, 2020 09:45
@torotil torotil requested a review from a team May 7, 2020 12:26
@torotil torotil merged commit 8343f53 into 7.x-2.x May 8, 2020
@torotil torotil deleted the remove-action-types branch May 8, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants