Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Angular Version): [On behalf of Planally Sdn Bhd]: Angular 18 migration #202

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

msibhuiyan
Copy link
Contributor

@msibhuiyan msibhuiyan commented Jun 25, 2024

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Other... Please describe: Angular 18 migration

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

version update for ngidle to 15.0.0

BREAKING CHANGE: 🧨 '
Angular migrated to version 18
Angular 18 migration test issue adaptation
updated version of angular fontawesome for compability issue
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling bfb00ca on planally:ng-18
into fc7d369 on moribvndvs:master.

@msibhuiyan msibhuiyan changed the title Ng 18 Angular 18 migration Jun 25, 2024
@moribvndvs
Copy link
Owner

So @ng-idle/core and keepalive both declare

"@angular/common": ">=17.3.10",
"@angular/core": ">=17.3.10"

as dependencies. Is this version sufficiently breaking that we need to bump these versions as well? I'm thinking maybe we don't since the packages don't export or otherwise rely on 18 specific things, with the exception of tests (which are irrelevant to consumers of these packages).

Introduced new control flow implementation for docs
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 250e0c3 on planally:ng-18
into fc7d369 on moribvndvs:master.

@msibhuiyan
Copy link
Contributor Author

@moribvndvs If not major, I believe we could publish a minor version, As the bundle itself goes with the latest version of angular in the docs.
In the future, newer version of Angular migration should go smoothly.

@msibhuiyan msibhuiyan changed the title Angular 18 migration chore(Version): [On behalf of Planally Sdn Bhd]: Angular 18 migration Jul 5, 2024
@msibhuiyan msibhuiyan changed the title chore(Version): [On behalf of Planally Sdn Bhd]: Angular 18 migration chore(Angular Version): [On behalf of Planally Sdn Bhd]: Angular 18 migration Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants