[fix](auth)fix simple auth check and default username (apache#35620)

fix simple auth check and default username we should set simple auth to valid by default, and check whether to set the default username in loginWithUGI
morningman · May 31, 2024 · 81fc589 · 81fc589
1 parent b93a175
commit 81fc589
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/HadoopUGI.java b/fe/fe-common/src/main/java/org/apache/doris/common/security/authentication/HadoopUGI.java
@@ -73,6 +73,7 @@ private static UserGroupInformation loginWithUGI(AuthenticationConfig config) {
             String hadoopUserName = ((SimpleAuthenticationConfig) config).getUsername();
             if (hadoopUserName == null) {
                 hadoopUserName = "hadoop";
+                ((SimpleAuthenticationConfig) config).setUsername(hadoopUserName);
                 LOG.debug(AuthenticationConfig.HADOOP_USER_NAME + " is unset, use default user: hadoop");
             }
             ugi = UserGroupInformation.createRemoteUser(hadoopUserName);

diff --git a/...main/java/org/apache/doris/common/security/authentication/SimpleAuthenticationConfig.java b/...main/java/org/apache/doris/common/security/authentication/SimpleAuthenticationConfig.java
@@ -18,14 +18,13 @@
 package org.apache.doris.common.security.authentication;
 
 import lombok.Data;
-import org.apache.commons.lang3.StringUtils;
 
 @Data
 public class SimpleAuthenticationConfig extends AuthenticationConfig {
     private String username;
 
     @Override
     public boolean isValid() {
-        return StringUtils.isNotEmpty(username);
+        return true;
     }
 }