Implementation of Sync Optimization for Movies, Series and Episodes #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Sync Only settings for movies, series and episodes.
This prevents a horrible, multiline, stack trace message from knowit and replaces it with a single clear log message.
Added Sync Only settings for movies, series and episodes. Used CollapseBox to hide messages if switches are off, so that user is not confused or overwhelmed.
Occasionally, Radarr will add an extra separator to the end of the path, which causes some of our comparisons to fail. Use os.path.normpath() to handle this. Also fixed cringeworthy code duplication of large code block which made it hard to see what the difference was and why.
Also removed code to detect separator.
Implemented algorithm. that (when the switch is on) will only check movies that are monitored, or whose monitored state does not agree between Bazarr and Radarr. Added statistics to indicate effectiveness of algorithm and logging to help with any potential further debugging. Updated comments to add reasoning behind code.
Added trace() method to wrap logging.debug() calls with a feature prefix to make it easy to filter out these messages when Bazarr is in logging DEBUG mode.
Added counter to trace() statements to make sure no movie was missed
Implemented algorithm. that (when the switch is on) will only check series that are monitored, or whose monitored state does not agree between Bazarr and Sonarr. Added statistics to indicate effectiveness of algorithm and logging to help with any potential further debugging. Added trace() method to wrap logging.debug() calls with a feature prefix to make it easy to filter out these messages when Bazarr is in logging DEBUG mode.
Implemented algorithm. that (when the switch is on) will only check episodes that are monitored, or whose monitored state does not agree between Bazarr and Sonarr. Added statistics to indicate effectiveness of algorithm and logging to help with any potential further debugging. Added trace() method to wrap logging.debug() calls with a feature prefix to make it easy to filter out these messages when Bazarr is in logging DEBUG mode.
Replace hard-coded magic number 20480 with MINIMUM_VIDEO_SIZE.
Changed "== None" comparison to "is None".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented algorithm, that (when the switches are on) will only check movies, series or episodes that are monitored, or whose monitored state does not agree between Bazarr and Radarr / Sonarr.
This can lead to a dramatic improvement in time spent synchronizing with Radarr and Sonarr if the user stops monitoring media that they are satisfied with in Radarr / Sonarr.
These settings are exposed in the UI under Settings -> Scheduler -> Sonarr/Radarr Sync.