Fix best forced subtitle downloads #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Searching for the best forced subtitles for a given language was resulting in all forced subtitles for that language being downloaded in descending score order until the minimum score was reached. Not only did this burn through any download limits imposed by providers, it left poor quality subtitles downloaded (which could later be automatically upgraded to the first choice). This change uses the string conversion of Language objects instead of their basenames when working out when to stop downloading subtitles, as this takes into account the forced flag while still ignoring the hearing impaired flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching for the best forced subtitles for a given language was resulting in all forced subtitles for that language being downloaded in descending score order until the minimum score was reached.
Not only did this burn through any download limits imposed by providers, it left poor quality subtitles downloaded (which could later be automatically upgraded to the first choice).
This change uses the string conversion of Language objects instead of their basenames when working out when to stop downloading subtitles, as this takes into account the forced flag while still ignoring the hearing impaired flag.