Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add search poster #2722

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: Add search poster #2722

merged 2 commits into from
Oct 23, 2024

Conversation

anderson-oki
Copy link
Collaborator

@anderson-oki anderson-oki commented Oct 16, 2024

Description

Add the poster as small thumbnail to the search results.

The logic of the duplication has been removed as now the display name can be shown even containing duplicated labels, but since we now have the posters, that can be judged by the users which one they are looking for.

We could had done more aggressive caching in the proxy, but to be honest the browser caching seems to be enough in both terms of performance and data usage, the poster will also be reused when the user navigates to the Series or Movie detail page.

The feature of allowing to search only Series, Movie or Both will be added on the future in a separated Pull Request.

Desktop:

image

Mobile:

Screenshot 2024-10-22 at 21 34 18

@anderson-oki anderson-oki self-assigned this Oct 16, 2024
@anderson-oki anderson-oki marked this pull request as ready for review October 16, 2024 02:41
@anderson-oki anderson-oki marked this pull request as draft October 16, 2024 13:41
@anderson-oki anderson-oki force-pushed the feature/search-revamp branch from a592755 to 41328d8 Compare October 21, 2024 00:20
@anderson-oki anderson-oki force-pushed the feature/search-revamp branch from 41328d8 to 0803457 Compare October 22, 2024 12:29
@anderson-oki anderson-oki changed the title feat: Add search poster and categories feat: Add search poster Oct 22, 2024
@anderson-oki anderson-oki marked this pull request as ready for review October 22, 2024 12:34
@anderson-oki anderson-oki requested a review from JaiZed October 22, 2024 12:34
Copy link
Collaborator

@JaiZed JaiZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, for whatever that’s worth!

@JaiZed
Copy link
Collaborator

JaiZed commented Oct 22, 2024

As a side comment (not directly related to these changes), if we run out of room on mobile for the search bar, can we replace the word BAZARR with the icon instead, since it takes up less space, rather than the other way around?

@morpheus65535
Copy link
Owner

It looks good to me too but who am I to judge that? ;-)

@anderson-oki
Copy link
Collaborator Author

anderson-oki commented Oct 23, 2024

As a side comment (not directly related to these changes), if we run out of room on mobile for the search bar, can we replace the word BAZARR with the icon instead, since it takes up less space, rather than the other way around?

I added a card for that on https://github.com/users/morpheus65535/projects/1/views/1?pane=issue&itemId=84438240

@anderson-oki anderson-oki merged commit e8077d6 into development Oct 23, 2024
2 checks passed
@anderson-oki anderson-oki deleted the feature/search-revamp branch October 23, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants