Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated features #888

Merged
merged 22 commits into from
Nov 4, 2024
Merged

Remove deprecated features #888

merged 22 commits into from
Nov 4, 2024

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Oct 16, 2024 •
edited
Loading

This PR removes the use of deprecated features. Changes inside src:

  • removes the use of the stable debt token
  • removes the use of e-mode price sources
  • removes the use of getEModeCategory, as there is not one category per asset anymore. Instead, the code verifies that assets are enabled in the current e-mode. Note that assets can now be enabled as collateral and/or as borrowable in a given e-mode category
  • replaces getEModeCategoryData with getEModeCategoryCollateralConfig, and changes the corresponding struct DataTypes.EModeCategoryLegacy with DataTypes.CollateralConfig
  • renaming stableDebtToken slot to _deprecated_stableDebtToken as it's deprecated now
    Screenshot from 2024-10-25 17-47-20

@QGarchery QGarchery self-assigned this Oct 16, 2024
@QGarchery QGarchery changed the title chore: in the middle of TestMarketLib Remove deprecated features Oct 16, 2024
@MathisGD MathisGD mentioned this pull request Oct 16, 2024
Closed
@QGarchery QGarchery mentioned this pull request Oct 17, 2024
Merged
@QGarchery QGarchery linked an issue Oct 17, 2024 that may be closed by this pull request
Document build method #889
Closed
@QGarchery QGarchery marked this pull request as ready for review October 17, 2024 15:09
@QGarchery QGarchery requested a review from MathisGD October 17, 2024 15:10
MathisGD
MathisGD reviewed Oct 25, 2024
View reviewed changes
src/libraries/Types.sol Outdated Show resolved Hide resolved
MathisGD
MathisGD reviewed Nov 3, 2024
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comments (+ the ones already open)

test/helpers/ForkTest.sol Outdated Show resolved Hide resolved
test/integration/TestIntegrationEModeNative.sol Outdated Show resolved Hide resolved
test/integration/TestIntegrationEModeNative.sol Outdated Show resolved Hide resolved
test/integration/TestIntegrationEModeNative.sol Show resolved Hide resolved
test/internal/TestInternalEMode.sol Show resolved Hide resolved
Base automatically changed from refactor/aave-v3-origin to develop November 4, 2024 08:53
MathisGD
MathisGD reviewed Nov 4, 2024
View reviewed changes
src/MorphoInternal.sol Outdated Show resolved Hide resolved
@QGarchery QGarchery merged commit 4ae8af1 into develop Nov 4, 2024
8 of 9 checks passed
@QGarchery QGarchery deleted the refactor/remove-deprecated branch November 4, 2024 13:38
@QGarchery QGarchery mentioned this pull request Nov 4, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document build method
2 participants
@QGarchery @MathisGD