Skip to content

Commit

Permalink
fix: apply suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
Jean-Grimal committed Oct 18, 2023
1 parent 4164acc commit 3c5d48c
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 11 deletions.
6 changes: 3 additions & 3 deletions src/ethereum/EthereumPermitBundler.sol
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ abstract contract EthereumPermitBundler is PermitBundler {
/// @param nonce The nonce of the signed message.
/// @param expiry The expiry of the signed message.
/// @param allowed Whether the initiator gives the bundler infinite Dai approval or not.
/// @param v signature.v
/// @param r signature.r
/// @param s signature.s
/// @param v The `v` component of a signature.
/// @param r The `r` component of a signature.
/// @param s The `s` component of a signature.
function permitDai(uint256 nonce, uint256 expiry, bool allowed, uint8 v, bytes32 r, bytes32 s, bool skipRevert)
external
payable
Expand Down
2 changes: 1 addition & 1 deletion src/migration/AaveV2MigrationBundler.sol
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ contract AaveV2MigrationBundler is MigrationBundler {

/* CONSTRUCTOR */

/// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments).
/// @dev Warning: assumes the aaveV2Pool address is non-zero (not expected to be deployment arguments).
/// @param morpho The Morpho contract Address.
/// @param aaveV2Pool The AaveV2 contract address.
constructor(address morpho, address aaveV2Pool) MigrationBundler(morpho) {
Expand Down
3 changes: 1 addition & 2 deletions src/migration/AaveV3MigrationBundler.sol
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ contract AaveV3MigrationBundler is MigrationBundler {

/* CONSTRUCTOR */

/// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments).
/// @dev AaveV3 contract address.
/// @dev Warning: assumes the aaveV3Pool address is non-zero (not expected to be deployment arguments).
/// @param morpho The Morpho contract Address.
/// @param aaveV3Pool AaveV3 contract address.
constructor(address morpho, address aaveV3Pool) MigrationBundler(morpho) {
Expand Down
2 changes: 1 addition & 1 deletion src/migration/AaveV3OptimizerMigrationBundler.sol
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ contract AaveV3OptimizerMigrationBundler is MigrationBundler {

/* CONSTRUCTOR */

/// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments).
/// @dev Warning: assumes the aaveV3Optimizer address is non-zero (not expected to be deployment arguments).
/// @param morpho The Morpho contract Address.
/// @param aaveV3Optimizer The AaveV3 optmizer contract address.
constructor(address morpho, address aaveV3Optimizer) MigrationBundler(morpho) {
Expand Down
6 changes: 3 additions & 3 deletions src/migration/CompoundV2MigrationBundler.sol
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ import {MigrationBundler, ERC20} from "./MigrationBundler.sol";
contract CompoundV2MigrationBundler is WNativeBundler, MigrationBundler {
/* IMMUTABLES */

/// @dev The address of the C_ETH contract.
/// @dev The address of the cETH contract.
address public immutable C_ETH;

/* CONSTRUCTOR */

/// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments).
/// @dev Warning: assumes the wNative address is non-zero (not expected to be deployment arguments).
/// @param morpho The Morpho contract Address.
/// @param wNative The address of the wNative token contract.
/// @param cEth The address of the C_ETH contract.
/// @param cEth The address of the cETH contract.
constructor(address morpho, address wNative, address cEth) WNativeBundler(wNative) MigrationBundler(morpho) {
C_ETH = cEth;
}
Expand Down
1 change: 0 additions & 1 deletion src/migration/CompoundV3MigrationBundler.sol
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {MigrationBundler, ERC20} from "./MigrationBundler.sol";
contract CompoundV3MigrationBundler is MigrationBundler {
/* CONSTRUCTOR */

/// @dev Warning: assumes the given addresses are non-zero (they are not expected to be deployment arguments).
/// @param morpho The Morpho contract Address.
constructor(address morpho) MigrationBundler(morpho) {}

Expand Down

0 comments on commit 3c5d48c

Please sign in to comment.