fix/20-harmonize-morpho-input-natspec #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
approved these changes
Oct 19, 2023
Rubilmax
approved these changes
Oct 20, 2023
|
Put "Changes Applied" on Cantina |
|
It seems there's a conflict |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Can we update this one? |
Jean-Grimal
force-pushed
the
fix/issue-20
branch
from
34ae639 to
b108666
Compare
Rubilmax
requested changes
Oct 30, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Rubilmax
approved these changes
Oct 30, 2023
|
Closed because redundant with #314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cantinasec/review-morpho-blue-1/issues/20
Should I also update the naming in the tests ?
I also realized that the notice natspec of the morpho functions could be improved.