Fix/skipRevert-documentation-issue-19 #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
reviewed
Oct 24, 2023
| @@ -15,7 +15,7 @@ import {BaseBundler} from "./BaseBundler.sol"; | |||
| abstract contract UrdBundler is BaseBundler { | |||
| /// @notice Claims `amount` of `reward` on behalf of `account` on the given rewards distributor, using `proof`. | |||
| /// @dev Assumes the given distributor implements IUniversalRewardsDistributor. | |||
| /// @dev Pass `skipRevert = true` to avoid reverting the whole bundle in case the proof expired. | |||
| /// @dev Pass `skipRevert = true` to avoid reverting the call in case the proof expired or frontrunned. | |||
There was a problem hiding this comment.
Suggested change
| /// @dev Pass `skipRevert = true` to avoid reverting the call in case the proof expired or frontrunned. | |
| /// @dev Pass `skipRevert = true` to avoid reverting the call in case the proof is frontrunned. |
There was a problem hiding this comment.
expired is important I think too
|
I think this PR should be done on top of the fix of https://github.com/cantinasec/review-morpho-blue-1/issues/28, or the opposite. How do you plan to do it @Jean-Grimal ? |
MerlinEgalite
approved these changes
Oct 24, 2023
Yes you are right, I am working on the fix of this issue right now, I'll handle it |
|
Moved to #302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cantinasec/review-morpho-blue-1/issues/19