rename "v2" (option 1) #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
commented
Mar 5, 2024
| import { | ||
| AaveV3OptimizerMigrationBundler, | ||
| IAaveV3Optimizer, | ||
| Signature as MA3Signature |
There was a problem hiding this comment.
I'm not sure with what this was clashing, but it works without now, so I removed it
MathisGD
requested review from
Jean-Grimal,
Rubilmax,
MerlinEgalite and
QGarchery
and removed request for
Jean-Grimal and
Rubilmax
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MerlinEgalite
approved these changes
Mar 5, 2024
QGarchery
approved these changes
Mar 5, 2024
Jean-Grimal
approved these changes
Mar 5, 2024
…-instances Rename v2 option 1 a couple additional text instances
MerlinEgalite
approved these changes
Mar 5, 2024
Rubilmax
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
Discussion https://morpholabs.slack.com/archives/C02N7CZ088N/p1709477616438119
I only renamed the deployed contracts, as discussed in #413