Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct CALL_FAILED description #447

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

adhusson
Copy link
Contributor

@adhusson adhusson commented Jul 9, 2024

Error description did not match usage. The error is used when trying to bubble up a failed called but the call has empty returndata. In that case, CALL_FAILED is thrown.

The description in ErrorsLib.sol did not correctly describe when CALL_FAILED was used.

QGarchery
QGarchery previously approved these changes Jul 9, 2024
src/libraries/ErrorsLib.sol Outdated Show resolved Hide resolved
Co-authored-by: Quentin Garchery <[email protected]>
Signed-off-by: Adrien Husson <[email protected]>
@adhusson adhusson requested a review from QGarchery July 9, 2024 11:21
@MathisGD MathisGD merged commit 3ea283f into main Jul 9, 2024
10 checks passed
@MathisGD MathisGD deleted the fix-call-failed-description branch July 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants