Check non-view non-multicall functions are protected #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It could be nice to have more comments informing what are you intending to verify, how and maybe even why, it's much nicer to start a review with a birds-eye view of what's going on. May just a simple description in the PR is nice. |
|
Good point, I've added a README.md modeled after those in the metamorpho and pre-liquidation repos and edited this PR's description. |
colin-morpho
approved these changes
Oct 30, 2024
QGarchery
approved these changes
Oct 31, 2024
colin-morpho
approved these changes
Oct 31, 2024
colin-morpho
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundler methods used during a bundle execution have the
protectedmodifier. This modifier ensures that:The
Protected.specfile checks that all bundler functions, except noted exceptions, respect the requirements of theprotectedmodifier when an initiator has been set.